Skip to content

refactor: use a more straightforward return value#1642

Open
beforetech wants to merge 4 commits intohyperledger:mainfrom
beforetech:main
Open

refactor: use a more straightforward return value#1642
beforetech wants to merge 4 commits intohyperledger:mainfrom
beforetech:main

Conversation

@beforetech
Copy link

@beforetech beforetech commented Feb 23, 2025 •
edited
Loading

Proposed changes

use a more straightforward return value

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)

Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

@beforetech
refactor: use a more straightforward return value
ac74c81 
Signed-off-by: beforetech <mail@before.tech>
@beforetech beforetech requested a review from a team as a code owner February 23, 2025 13:47
EnriqueL8
EnriqueL8 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (83e4cbe) to head (16324aa).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1642   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         342      342           
  Lines       30439    30439           
=======================================
  Hits        30427    30427           
  Misses          8        8           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@beforetech
Copy link
Author

beforetech commented May 22, 2025

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EnriqueL8 EnriqueL8 EnriqueL8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beforetech @EnriqueL8